Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-10796

No more QML profiler since latest changes in welcome screen

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • None
    • Qt Creator 3.0.0-beta
    • QML Profiler
    • None
    • 50b61dbe4e091bfc60d064e24f4a44ab203fb70d

    Description

      Since 87ea12a6 the QML profiler doesn't show anymore. The changes of that commit seem unrelated, though:

      diff --git a/src/plugins/welcome/welcomeplugin.cpp b/src/plugins/welcome/welcomeplugin.cpp
      index da1aa21..5502f24 100644
      --- a/src/plugins/welcome/welcomeplugin.cpp
      +++ b/src/plugins/welcome/welcomeplugin.cpp
      @@ -165,16 +165,15 @@ WelcomeMode::WelcomeMode() :
           styledBar->setObjectName(QLatin1String("WelcomePageStyledBar"));
           layout->addWidget(styledBar);
       
      -    // QScrollArea *scrollArea = new QScrollArea(m_modeWidget);
      -    // scrollArea->setFrameShape(QFrame::NoFrame);
      -    // layout->addWidget(scrollArea);
      -    // scrollArea->setWidget(m_welcomePage);
      -    // scrollArea->setWidgetResizable(true);
      +    QScrollArea *scrollArea = new QScrollArea(m_modeWidget);
      +    scrollArea->setFrameShape(QFrame::NoFrame);
      +    scrollArea->setWidgetResizable(true);
       
      -    QWidget *container = QWidget::createWindowContainer(m_welcomePage, m_modeWidget);
      +    QWidget *container = QWidget::createWindowContainer(m_welcomePage, scrollArea);
           container->setMinimumSize(QSize(880, 548));
      -    layout->addWidget(container);
      +    scrollArea->setWidget(container);
           m_modeWidget->setLayout(layout);
      +    layout->addWidget(scrollArea);
       
           connect(PluginManager::instance(), SIGNAL(objectAdded(QObject*)), SLOT(welcomePluginAdded(QObject*)));
      
      

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              con Eike Ziller
              ulherman Ulf Hermann
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes