Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-11266

'+' character deemed invalid for file names, shouldn't be (PATCH)

    XMLWordPrintable

Details

    • d008e8f2b6db8204639f894a68e7ec30899d2a73

    Description

      QtCreator's C++ file naming options let you choose the extension to use for source files, with ".c+" being one of the options. However, the file creation dialog refuses to create such files, giving the error "Invalid character ''" and disabling the "next" button.

      I've used ".c+" for some time and never had any problem. Every filesystem I've tried (ext4, HFS, NTFS, VFAT, UFS) supports '+' in filenames. So I think this should be allowed.

      --- a/src/lib/utils/filenamevalidatinglineedit.cpp
+++ b/src/libs/utils/filenamevalidatinglineedit.cpp
@@ -97,8 +97,8 @@
 
 #define SLASHES "/\\"
 
-static const char notAllowedCharsSubDir[]   = ",^@=+{}[]~!?:&*\"|#%<>$\"'();`' ";
-static const char notAllowedCharsNoSubDir[] = ",^@=+{}[]~!?:&*\"|#%<>$\"'();`' " SLASHES;
+static const char notAllowedCharsSubDir[]   = ",^@={}[]~!?:&*\"|#%<>$\"'();`' ";
+static const char notAllowedCharsNoSubDir[] = ",^@={}[]~!?:&*\"|#%<>$\"'();`' " SLASHES;
 
 static const char *notAllowedSubStrings[] = {".."};

      Attachments

        For Gerrit Dashboard: QTCREATORBUG-11266
        # Subject Branch Project Status CR V
        76587,1 Allow + for file names in file wizard 3.0 qt-creator/qt-creator Status: MERGED +2 0

        Activity

          People

            con Eike Ziller
            kenton Kenton Varda
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes