Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-13324

Use of NULL pointer in qmljstypedescriptionreader.cpp

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • Qt Creator 3.3.0
    • Qt Creator 2.5.0-beta, Qt Creator 3.3.0-rc1
    • Quick / QML Support
    • None
    • 4b0992568f01ce09cbfb5464072f30f40c114abf

    Description

      Look at lines 499ff in src/libs/qmljs/qmljstypedescriptionreader.cpp:

          if (!ast || !ast->statement) {
              addError(ast->colonToken, tr("Expected numeric literal after colon."));
              return invalidVersion;
          }
      

      I expect a crash there if ast is NULL.

      Please double-check this and fix it if needed.

      Found by Clang Static Analyzer.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            fawzi Fawzi Mohamed
            rlohning Robert Löhning
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes