Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-14469

[REG 3.4.0 -> 3.4.1] "Rename..." moves file from HEADERS to DISTFILES when removing suffix

    XMLWordPrintable

Details

    Description

      1. Open the attached project. It's from the QtMobility examples of Qt4.
      2. In Projects view, right-click on utility.h and select "Rename..." from the context menu.
      3. Enter a name without a suffix, e.g. "util".
      4. See the pro-file.
        utility.h was removed from HEADERS. util was added in DISTFILES.

      The same happens with a source file. Creator 3.4.0 lists the changed files in SOURCES and I think this was better. This worked until this change was added:

      59da3a2bba6cc3b8552695d9588dab9b1530cec0 is the first bad commit
      commit 59da3a2bba6cc3b8552695d9588dab9b1530cec0
      Author: BogDan Vatra <bogdan@kde.org>
      Date:   Fri May 15 15:46:37 2015 +0300
      
          Override text/x-csrc mimetype with QtCreator's own version
      
          It is necessarye because fredesktop's version searches for /* and // magic
          which is found in other files (e.g. .qml, .js, etc.)
      
          Change-Id: I9cd3341167e5a0aa57d6046f4492bab241055c4b
          Reviewed-by: Eike Ziller <eike.ziller@theqtcompany.com>
      

      Found and tested by Squish test tst_rename_file.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              dt Daniel Teske
              rlohning Robert Löhning
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes