Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-16619

xgejom.bat and ibjom.bat suppress errors

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P4: Low
    • None
    • Qt Creator 4.1.0-beta1
    • Jom
    • None

    Description

      To reproduce you may temporarily replace the `xgConsole` in `xgejom.bat` with a non-existent tool. For example so:

      --- a/xgejom.bat
      +++ b/xgejom.bat
      @@ -2,5 +2,5 @@
       setlocal
      --- a/xgejom.bat
      +++ b/xgejom.bat
      @@ -2,5 +2,5 @@
       setlocal
       if "%IBJOM_NUMBEROFJOBS%" == "" set IBJOM_NUMBEROFJOBS=60
       set NINJAFLAGS=-j60
      -xgConsole /profile="%~dp0\xgejom.xml" /command="jom -j%IBJOM_NUMBEROFJOBS% %*"
      +xgNotThere /profile="%~dp0\xgejom.xml" /command="jom -j%IBJOM_NUMBEROFJOBS% %*"
       endlocal
      

      Next in the CMD window, issue:

      > xgejom.bat && echo "SUCCESS"
      

      The result is:

      Der Befehl "xgNotThere" ist entweder falsch geschrieben oder
      konnte nicht gefunden werden.
      "SUCCESS"
      

      The problem is that the "SUCCESS" is seen. It shouldn't.

      I believe this is due to the "setlocal", "endlocal" in the script. As both "xgConsole" and "BuildCosole" tools are executables and the script doesn't CALL out other scripts, I don't see a need for using "setlocal/endlocal" and would advice to remove those.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            jbornema Joerg Bornemann
            piotr_pietraszkiewicz Piotr Pietraszkiewicz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes