Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-17752

GenericProposal leaks

XMLWordPrintable

      See one ctor of GenericProposal:

      GenericProposal::GenericProposal(int cursorPos, const QList<AssistProposalItemInterface *> &items)
    : IAssistProposal(cursorPos)
    , m_model(new GenericProposalModel)
{
    m_model->loadContent(items);
}

      This allocates a new GenericProposalModel but does not delete it:

      GenericProposal::~GenericProposal()
{}

      Some calling code seems to take care of deleting the model, other doesn't.

      You should make sure that m_model is always deleted properly.

        For Gerrit Dashboard: QTCREATORBUG-17752
        # Subject Branch Project Status CR V
        196518,4 CodeAssist: Fix leaking proposal model 4.3 qt-creator/qt-creator Status: MERGED +2 0
        220269,3 CodeAssist: use shared pointer to pass around proposal models master qt-creator/qt-creator Status: MERGED +2 0

            davschul David Schulz
            rlohning Robert Löhning
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes