Details
-
Bug
-
Resolution: Fixed
-
P3: Somewhat important
-
Qt Creator 4.9.0
-
None
-
20cd55046f (qt-creator/qt-creator/9.0) 1593f869ed (qt-creator/qt-creator/qds/dev) 20cd55046f (qt-creator/qt-creator/qds/dev)
Description
- Open a file from a git repository.
- Change and save the file.
- Open the git commit editor ("Tools" -> "Git" -> "Local Repository" -> "Commit...").
- Try to close the git commit editor.
You'll get a message box asking you: "Cannot commit: Description is empty. What do you want to do?"
It's clear what the user wants to do: Close the editor. There's no intention to commit at this point. - Click "Keep Editing".
- Check the file in the "Files" section of the dialog and type some description.
- Try to close the git commit editor.
You'll get a message box asking you: "What do you want to do with these changes?" and three options.
This is the message which should have been shown in step 4.
The right order is:
- User tries to close editor. Ask how to proceed:
- Keep Editing: Do nothing
- Close: Close the editor
- Commit: Check whether commit is possible:
- Possible: Commit
- Not Possible: Ask what to do:
- Keep Editing: Do nothing
- Close: Close the editor
Or, even better: When committing is not possible, disable the "Commit" button in the first place.
Attachments
Issue Links
- relates to
-
QTCREATORBUG-18799 Improve buttons when closing git editor
-
- Closed
-