Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-22233

Wrong order of questions when closing git commit editor

    XMLWordPrintable

Details

    • 20cd55046f (qt-creator/qt-creator/9.0) 1593f869ed (qt-creator/qt-creator/qds/dev) 20cd55046f (qt-creator/qt-creator/qds/dev)

    Description

      1. Open a file from a git repository.
      2. Change and save the file.
      3. Open the git commit editor ("Tools" -> "Git" -> "Local Repository" -> "Commit...").
      4. Try to close the git commit editor.
        You'll get a message box asking you: "Cannot commit: Description is empty. What do you want to do?"
        It's clear what the user wants to do: Close the editor. There's no intention to commit at this point.
      5. Click "Keep Editing".
      6. Check the file in the "Files" section of the dialog and type some description.
      7. Try to close the git commit editor.
        You'll get a message box asking you: "What do you want to do with these changes?" and three options.
        This is the message which should have been shown in step 4.

      The right order is:

      • User tries to close editor. Ask how to proceed:
        • Keep Editing: Do nothing
        • Close: Close the editor
        • Commit: Check whether commit is possible:
          • Possible: Commit
          • Not Possible: Ask what to do:
            • Keep Editing: Do nothing
            • Close: Close the editor

      Or, even better: When committing is not possible, disable the "Commit" button in the first place.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              orgads Orgad Shaneh
              rlohning Robert Löhning
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes