Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-23562

Duplicate code in the QtOutputFormatter and PythonOutputFormatter

    XMLWordPrintable

Details

    • All
    • aeb7ef6b37030ed4beb8f431167d2ef88172486b (qt-creator/qt-creator/master)

    Description

      There are two identical (at least for me) static linkFormat functions here:

      https://github.com/qt-creator/qt-creator/blob/master/src/plugins/python/pythonrunconfiguration.cpp#L63

       

      And here:

       

      https://github.com/qt-creator/qt-creator/blob/master/src/plugins/qtsupport/qtoutputformatter.cpp#L233

       

      I am working on the #QTCREATORBUG-23536 where I would need the very same function and I feel that adding a 3rd function is not the way to go .

      Is there any objection about moving that function to the Outputformatter?

       

      Attachments

        For Gerrit Dashboard: QTCREATORBUG-23562
        # Subject Branch Project Status CR V
        289274,4 Remove duplicated code master qt-creator/qt-creator Status: MERGED +2 0

        Activity

          People

            martonmiklos Miklós Márton
            martonmiklos Miklós Márton
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes