Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-24077

Regression, ProposalWidget is not updated upon pressing left arrow

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Duplicate
    • Affects Version/s: Qt Creator 4.12.0-beta1
    • Fix Version/s: None
    • Labels:
      None
    • Environment:
      Kubuntu 20.04
    • Platform/s:
      Linux/X11

      Description

      This commit - 909cb3859b1b68408cbf71354c95b6bf39d15c12, which fixed QTCREATORBUG-15038, also introduced a regression.

      How to reproduce the regression:
      If you have some text, for example `std::move(something)`:

      • put cursor after `::`
      • press Ctrl+Space (`ProposalWidget` should appear)
      • press left arrow

      The content of the window will NOT be adjusted/updated to the first letter, while it should. Essentially `ProposalWidget` seems to be just dead.

      My experiments showed that restoring

        if (isVisible())
          d->m_assistant->notifyChange();
      

      in plugins/texteditor/codeassist/genericproposalwidget.cpp fixes the regression and does not re-introduce the bug described here - QTCREATORBUG-15038

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              davschul David Schulz
              Reporter:
              dimanne DimanNe
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes