Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-24215

Many functions are missing override or final specifier

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Not Evaluated
    • None
    • Qt Creator 4.13.0-beta1
    • Building Qt Creator
    • None

    Description

      After the introduction of the override and final specifiers in C++, Qt Creator's code base slowly adapted the habit to use override or final on function level and final on class level.

      Running clang-tidy with the modernize-use-override reveals that many overridden virtual functions are either without any specifier or still (redundantly) specified as virtual.

      See the diff after a clang-tidy run: https://codereview.qt-project.org/c/qt-creator/qt-creator/+/304301

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            portale Alessandro Portale
            portale Alessandro Portale
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes