Details
-
Bug
-
Resolution: Done
-
Not Evaluated
-
None
-
Qt Creator 4.14.0, Qt Creator 6.0.0-beta2
-
None
-
Ubuntu 20.04 LTS
Description
Applying the fix its suggested by clang tidy -wreadability-convert-member-functions-to-static produces garbled code for const member funcs with multiline declarations.
class Foo { public: void test1(int a, int b, int c) const; void test2(int a, int b, int c) const; }; void Foo::test1(int a, int b, int c) const { qDebug() << a << b << c; } void Foo::test2(int a, int b, int c) const { qDebug() << a << b << c; }
becomes
class Foo { public: static void test1(int a, int b, int c) const; static void test2(int a, int b, int c); }; void Foo::test1(int a, int b, int c) const { qDebug() << a << c; } void Foo::test2(int a, int b, int c) c{ qDebug() << a << b << c; }
Note const is not removed, occasionally trailing blanks are left in the source and declarations can be quite badly broken. https://codereview.qt-project.org/c/pyside/pyside-setup/+/331199 required many manual corrections.
Attachments
Issue Links
- relates to
-
QTCREATORBUG-20827 Fixits still applied at wrong offset
- Closed