Details
-
Bug
-
Resolution: Fixed
-
P1: Critical
-
Qt Creator 5.0.0-beta1
-
None
-
MinGW Compiler (on Windows)
-
-
d9cf979d6d1d99051be60aebeb78c28a6251249b (qt-creator/tqtc-qt-creator/master)
Description
Since a7fc1631a707e067d3b90d79d6f514096891b20dit fails to link said plugin:
ld.exe: client.o:client.cpp:(.text+0x12af2): undefined reference to `__imp__ZN22LanguageServerProtocol29WorkDoneProgressCreateRequest10metho dNameE' ld.exe: client.o:client.cpp:(.text+0x12bec): undefined reference to `__imp__ZN22LanguageServerProtocol20ProgressNotification10methodNameE' ld.exe: languageclientmanager.o:languageclientmanager.cpp:(.text+0x45f6): undefined reference to `__imp__ZN22LanguageServerProtocol29WorkDoneProgressCreateRequest10methodNameE' ld.exe: languageclientmanager.o:languageclientmanager.cpp:(.text+0x4642): undefined reference to `__imp__ZN22LanguageServerProtocol20ProgressNotification10methodNameE' ld.exe: progressmanager.o:progressmanager.cpp:(.text+0x34f): undefined reference to `__imp__ZN22LanguageServerProtocol22WorkDoneProgressReport10messageKeyE' ld.exe: progressmanager.o:progressmanager.cpp:(.text+0x3b8): undefined reference to `__imp__ZN22LanguageServerProtocol22WorkDoneProgressReport13percentageKeyE' ld.exe: progressmanager.o:progressmanager.cpp:(.text+0x899): undefined reference to `__imp__ZN22LanguageServerProtocol19WorkDoneProgressEnd10messageKeyE' ld.exe: progressmanager.o:progressmanager.cpp:(.text+0xbbc): undefined reference to `__imp__ZN22LanguageServerProtocol21WorkDoneProgressBegin8titleKeyE'
I had the same issue with my own code, constexpr static variables are not exported in the DLL, I had done something like:
#ifdef Q_OS_WIN # ifdef BUILD_LVS_LIBRARY # define EXPORT_LVS_LIB __declspec(dllexport) # else # define EXPORT_LVS_LIB __declspec(dllimport) # endif # define EXPORT_LVS_LIB_CONSTEXPR __declspec(dllexport) #else # ifdef BUILD_LVS_LIBRARY # define EXPORT_LVS_LIB __attribute((visibility("default")) # define EXPORT_LVS_LIB_CONSTEXPR __attribute((visibility("default")) # else # define EXPORT_LVS_LIB # define EXPORT_LVS_LIB_CONSTEXPR # endif #endif
No idea how you want to handle stuff like that, otherwise I had created a change.
Attachments
For Gerrit Dashboard: QTCREATORBUG-25544 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
342129,2 | LSP: fix MinGW build | master | qt-creator/qt-creator | Status: MERGED | +2 | 0 |