Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-26415

locator command slow

    XMLWordPrintable

Details

    • 93ae6f4c06775626db2b2527f7b0c550bf1ea8c4 (qt-creator/qt-creator/6.0)

    Description

      the locator command became very slow for me: `:` to list symbols takes minutes to show up on my (non-trivial, but not enormous) codebase.

      most of the cpu time seems to be spent in `LocatorFilterEntry::operator==`, mainly in `QVariant::canConvert`/`QVariant::toString` (i guess one could use `QVariant::metaType()::equals()` in a fast-path when both `internalData` has the same type (which seems to be the default case).

      however i still wonder if there could be better ways to improve the speed of the locator command e.g. by lazily filtering only the first tens of entries to populate the popup (i guess otherwise the filter is applied to tens/hundert thousands of c++ symbols)

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-25996 Locator CppIncludesFilter is slow and doesn't cancel well

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Task - A task that needs to be done. QTCREATORBUG-24098 Port to Qt 6

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          replaces

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-25996 Locator CppIncludesFilter is slow and doesn't cancel well

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-26378 Locator spins pretty long and does no more update

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTCREATORBUG-26415
          # Subject Branch Project Status CR V
          377312,3 Fix performance issue in Locator with Qt 6 6.0 qt-creator/qt-creator Status: MERGED +2 0

          Activity

            People

              con Eike Ziller
              timblechmann tim blechmann
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes