Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-28494

Android plugin contains duplicated, coincidently deactivated code

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Not Evaluated
    • Qt Creator 9.0.1
    • Qt Creator 9.0.0
    • Android Support
    • None
    • 6f7837e5e (master)

    Description

      Much of the gradle handling code in the Android Plugin
      https://code.qt.io/cgit/qt-creator/qt-creator.git/tree/src/plugins/android/androidmanager.cpp#n619

      Is very similar to gradle handling code in androiddeployqt:
      https://code.qt.io/cgit/qt/qtbase.git/tree/src/tools/androiddeployqt/main.cpp#n2503

      I believe it was copied from Qt Creator to Qt a while back and slightly diverged in the meantime.

      Also, by coincidence, the manipulation of gradle files by the Android plugin got deactivated a few Years, ago:
      https://codereview.qt-project.org/c/qt-creator/qt-creator/+/444957

      Shall the code in Qt Creator be re-activated? Or should it be removed?

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            portale Alessandro Portale
            portale Alessandro Portale
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes