Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-29237

FTBFS: qmldesigner enables -Werror but uses deprecated declarations

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Not Evaluated
    • None
    • Qt Creator 12.0.0
    • Building Qt Creator, Quick Designer
    • None
    • 278d69df4 (qds/dev), 5e61d46e4 (qds/dev)

    Description

      In src/plugins/qmldesigner/CMakeLists.txt

      extend_qtc_library(QmlDesignerUtils
    CONDITION NOT DISABLE_COMPILE_WARNING_AS_ERROR
    PROPERTIES COMPILE_WARNING_AS_ERROR ON
)

      There's no disabling of the warnings for the use of deprecated entities or downgrading the errors back to warnings. This causes the build to fail:

      src/plugins/qmldesigner/designercore/imagecache/imagecacheconnectionmanager.cpp:48:63: error: ‘static int QMetaType::type(const char*)’ is deprecated [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/model/propertycontainer.cpp:44:21: error: ‘QVariant::Type QVariant::type() const’ is deprecated: Use typeId() or metaType(). [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/model/propertyparser.cpp:203:31: error: ‘static int QMetaType::type(const char*)’ is deprecated [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/model/propertyparser.cpp:268:43: error: ‘static int QMetaType::type(const char*)’ is deprecated [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/model/propertyparser.cpp:272:49: error: ‘Type’ is deprecated: Use QMetaType::Type instead. [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/model/propertyparser.cpp:272:26: error: ‘bool QVariant::convert(int)’ is deprecated [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/model/propertyparser.cpp:280:50: error: ‘static const char* QMetaType::typeName(int)’ is deprecated [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/instances/nodeinstance.cpp:299:34: error: ‘QVariant::Type QVariant::type() const’ is deprecated: Use typeId() or metaType(). [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/instances/nodeinstance.cpp:315:41: error: ‘QVariant::Type QVariant::type() const’ is deprecated: Use typeId() or metaType(). [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/instances/nodeinstance.cpp:334:41: error: ‘QVariant::Type QVariant::type() const’ is deprecated: Use typeId() or metaType(). [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/instances/nodeinstance.cpp:420:26: error: ‘QVariant::Type QVariant::type() const’ is deprecated: Use typeId() or metaType(). [-Werror=deprecated-declarations]
src/plugins/qmldesigner/designercore/model/modelmerger.cpp:86:30: error: ‘qsizetype QString::count() const’ is deprecated: Use size() or length() instead. [-Werror=deprecated-declarations]

      Attachments

        Issue Links

          relates to

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QDS-10014 Improve version management

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open
          resulted from

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-29238 qmldesigner turns -Werror on by default

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTCREATORBUG-29237
          # Subject Branch Project Status CR V
          481078,3 Fix deprecated function calls qds/dev qt-creator/tqtc-plugin-qtquickdesigner Status: MERGED +2 0
          481079,9 QmlDesigner: Fix deprecated function calls qds/dev qt-creator/qt-creator Status: MERGED +2 0

          Activity

            People

              bubke Marco Bubke
              thiago Thiago Macieira
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes