Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-31942

Audit uses of FilePath::withExecutableSuffix()

    XMLWordPrintable

Details

    • Task
    • Resolution: Won't Do
    • P3: Somewhat important
    • None
    • None
    • All Other Issues
    • None

    Description

      We have around 100 uses of FilePath::withExecutableSuffix() that might not be needed, and in the context of cross Window->*nix setups even be harmful, see https://bugreports.qt.io/browse/QTCREATORBUG-31939.

      As first approximation: FilePaths that are actually used to start processes will likely not need it, but FilePaths used elsewhere (e.g. comparisons with others) may need it.

      Would be good to remove the ones that are not needed and to add a short comment why they are needed on the ones that are needed.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              ansemkiv Andrii Semkiv
              hjk hjk
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes