Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-33001

LSP formatting is canceled during save

    XMLWordPrintable

Details

    Description

      Resulted from https://codereview.qt-project.org/c/qt-creator/qt-creator/+/647402

      The language client formatter is incorrectly canceling formatting
      requests when invoked from "Auto Format on Save" because of the logic
      in the handler of QTextDocument::contentsChanged signal. This signal
      is emitted both when formatting begins/ends and when the document is saved
      and this created a condition where formatting would work when manually
      triggered via context menu but fail during auto formatting on save.

      We need a mechanism that differantiates user edited changes and document changes after saving.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            davschul David Schulz
            semih.yavuz Semih Yavuz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes