Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-5604

Fakevim highlight matching is unreadable when using a dark colorscheme

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P3: Somewhat important P3: Somewhat important
    • Qt Creator 4.14.0
    • Qt Creator 2.3.0-beta
    • FakeVim
    • None
    • 00be04e1ea3b91849f963c9bca4d633fbdc352bc

      If you are using a dark colorscheme, and do a search for text, the highlight (background) color can match the foreground (text) color, making the text completely disappear.

      In the void FakeVimHandler::Private::highlightMatches(const QString &needle) function, the background color is set, but not the foreground color:

      sel.format.setBackground(QColor(177, 177, 0));

      I changed this color to be more readable, and added the foreground color change as well:

      sel.format.setBackground(QColor(151, 113, 255));
      sel.format.setForeground(Qt::black);

      Ideally, these colors should be set from the colorscheme itself, rather than being hard coded, but until then, this is a quick fix.

        For Gerrit Dashboard: QTCREATORBUG-5604
        # Subject Branch Project Status CR V

            hjk hjk
            steventomer Steven Tomer
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes