Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
Qt Creator 2.3.0-beta
-
None
-
00be04e1ea3b91849f963c9bca4d633fbdc352bc
Description
If you are using a dark colorscheme, and do a search for text, the highlight (background) color can match the foreground (text) color, making the text completely disappear.
In the void FakeVimHandler::Private::highlightMatches(const QString &needle) function, the background color is set, but not the foreground color:
sel.format.setBackground(QColor(177, 177, 0));
I changed this color to be more readable, and added the foreground color change as well:
sel.format.setBackground(QColor(151, 113, 255));
sel.format.setForeground(Qt::black);
Ideally, these colors should be set from the colorscheme itself, rather than being hard coded, but until then, this is a quick fix.
Attachments
For Gerrit Dashboard: QTCREATORBUG-5604 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
2556,1 | fakevim: also set foreground color for search matches | master | qt-creator/qt-creator | Status: MERGED | +2 | 0 |
2576,1 | fakevim: also set foreground color for search matches | 2.3 | qt-creator/qt-creator | Status: MERGED | +2 | 0 |