Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-6883

unsafe usage of QUrl in the HTML5 app wizard boilerplate

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Done
    • Affects Version/s: Qt Creator 2.3.1
    • Fix Version/s: Qt Creator 2.5.0-rc
    • Component/s: All Other Issues
    • Labels:
      None
    • Commits:
      f34e0bbfdf550d3bcbf797180559e9c25e6ce549

      Description

      void Html5ApplicationViewer::loadFile(const QString &fileName)
      {
      m_d->m_webView->setUrl(QUrl(Html5ApplicationViewerPrivate::adjustPath(fileName)));
      }

      Should be using QUrl::fromLocalFile, as toLocalFile does not work for urls without a file: scheme.
      Currently the generated code does not work on Qt 4.8.0 (we are discussing reverting to the old behaviour in 4.8.1 on qt-development mailing list)
      And it won't work on Qt5

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              portale Alessandro Portale
              Reporter:
              shkearns Shane Kearns
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes