Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-1265

Unstable component installed

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.1.0
    • Component/s: General
    • Labels:
      None

      Description

      Unstable component is installed if it is

      • fetched from category
      • selected by default
      • contains missing dependency

      Problem is in this code:

              storeCheckState();
      
              foreach (QInstaller::Component *component, components)
                  component->setCheckState(Qt::Checked);
      
              clearInstallerCalculator();
              if (installerCalculator()->appendComponentsToInstall(components.values()) == false) {
                  MessageBoxHandler::critical(MessageBoxHandler::currentBestSuitParent(), QLatin1String("Error"),
                      tr("Unresolved dependencies"), installerCalculator()->componentsToInstallError());
                  return false;
              }
      
              restoreCheckState();
      

      The unstable component is marked as unstable and thus unselected in appendComponentsToInstall(). However, as the check state is stored (storeCheckState() and restored (restoreCheckState() the component gets reselected.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            kamartti Katja Marttila
            Reporter:
            kamartti Katja Marttila
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes