Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-542

IFW/7zip doesn't compile with Qt 5.4/ MSVC 2013

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P2: Important
    • 2.0.0
    • 2.0.0
    • General
    • None
    • 9a7e8562fce16aa90c59dd48a7b8d8e4bf137bfb

    Description

      Trying to compile the master branch with msvc 2013 fails in 7zip:

      D:\dev\ifw\master\src\src\libs\7zip\win\CPP\7zip\UI\Common\Update.cpp:905: error: C2664: 'MY_MAPISENDDOCUMENTS' : cannot convert argument 2 from 'const char [2]' to 'LPSTR'
Conversion from string literal loses const qualifier (see /Zc:strictStrings)

      The code looks indeed 'suspicious':

            fnSend(0, ";", (LPSTR)(LPCSTR)path, (LPSTR)(LPCSTR)name, 0);

      Attachments

        For Gerrit Dashboard: QTIFW-542
        # Subject Branch Project Status CR V
        94393,2 Fix build with Qt 5.4 and MSVC2013 (release) master installer-framework/installer-framework Status: MERGED +2 0

        Activity

          People

            kkohne Kai Köhne
            kkohne Kai Köhne
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes