Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-591

Installscripts in Updates.xml are ignored

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Not Evaluated
    • 2.0.0
    • 2.0.0
    • General
    • None

    Description

      On the latest master branch (i.e. commit 5b5ee638) install script sections within Updates.xml files (generated from the repogen binary) are ignored cause of the wrong capitalization of the tag name "Script".

      Details:

      • repogen copies config blocks named "Script" (defined in repositorygen.cpp #288)
      • component.cpp reads in the script tag (component.cpp #312) with the defined constant "script" (constants.h #45)
      • The key "script" can't be found in the data structure and therefore install scripts are ignored at all

      Possible fixes:

      • Change the defined constant to uppercase (all other comparisons are case insensitive as far as I've seen)
      • Use another constant for the script tag itself (both in repositorygen and in package)
      • ... ?

      Hint: Changing the tag name in repositorygen.cpp to lower-case might not be a good idea as this breaks backwards compatibility (and documentation: http://doc-snapshot.qt-project.org/qtifw-master/ifw-component-description.html)

      (Installer 1.6 is not affected as this was merged in later on.)

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            installerteam Installer Team
            alexleutgoeb Alex Leutgöb
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes