Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-780

mkdmg.sh script used by binarycreator doesn't actually generate random file name

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Done
    • Affects Version/s: 2.0.1
    • Fix Version/s: 3.1.0, 3.0.1
    • Component/s: General
    • Labels:
      None
    • Environment:
      OS X 10.10.5

      Description

      The binarycreator uses a mkdmg.sh helper script at runtime to create .dmg file if requested. This script performs the following assignment:

      DMG=`mktemp "/tmp/$VOL.XXXXXX.dmg"`
      

      This doesn't actually create a random file name. OS X uses the BSD implementation of mktemp. The man page explains:

      The trailing `Xs' are replaced with the current process number and/or a unique letter combination.

      (emphasis by me).

      Hence, on OS X, the `XXXXXX` part should be at the end of the template. Alas, the patch isn't that trivial since that causes the `hdiutil` used further down in the script to no longer recognize the image file format correctly.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            installerteam Installer Team
            Reporter:
            frerich Frerich Raabe
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes