Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-829

crashes under windows when not having the focus

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Not Evaluated
    • None
    • 2.0.1, 3.1.0, Some future release
    • General
    • None
    • windows 10

    Description

      The QTIFW crashes in the PerformInstallationForm on the windows-platform when the installer-window loses the focus before changing to PerformInstallationPage. The reason is a missing check for a NULL-pointer around line 190 in performinstallationform.cpp:

      #ifdef Q_OS_WIN
      if (m_taskButton)

      { if (!m_taskButton->window()) m_taskButton->setWindow(QApplication::activeWindow()->windowHandle()); m_taskButton->progress()->setValue(progressPercentage); }

      #endif

      should be:

      #ifdef Q_OS_WIN
      if (m_taskButton)

      { if (!m_taskButton->window() && QApplication::activeWindow()) m_taskButton->setWindow(QApplication::activeWindow()->windowHandle()); m_taskButton->progress()->setValue(progressPercentage); }

      #endif

      A patch is attached too.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              installerteam Installer Team
              bratfisch Tobias
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes