Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-851

set proper build parameters for QTIF builds using ICC on Winfows

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Done
    • Icon: Not Evaluated Not Evaluated
    • 3.1.0, 3.0.1
    • 3.1.0
    • General
    • None

      For QTIF builds using ICC on Windows, compiler could receive improper parameters (or not receive proper), because used conditions for MSVC doesn't cover ICC builds.

      The fix is simple replacing string win32-msvc* with msvc in all *.pri and *.pro files (diff added in attachment).

      Similar patch was recently merged to Qt Creator project (see https://codereview.qt-project.org/#/c/157067 ) and there was no regressions with it.

      Regards
      Alexander

        1. qtif_icc_build_fix.diff
          0.6 kB
        For Gerrit Dashboard: QTIFW-851
        # Subject Branch Project Status CR V
        157946,3 Fix building with ICC on Windows master installer-framework/installer-framework Status: MERGED +2 0

            installerteam Installer Team
            sav sav
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes