Uploaded image for project: 'Qt Installer Framework'
  1. Qt Installer Framework
  2. QTIFW-851

set proper build parameters for QTIF builds using ICC on Winfows

    XMLWordPrintable

    Details

    • Type: Suggestion
    • Status: Closed
    • Priority: Not Evaluated
    • Resolution: Done
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.1.0, 3.0.1
    • Component/s: General
    • Labels:
      None
    • Environment:

      Description

      For QTIF builds using ICC on Windows, compiler could receive improper parameters (or not receive proper), because used conditions for MSVC doesn't cover ICC builds.

      The fix is simple replacing string win32-msvc* with msvc in all *.pri and *.pro files (diff added in attachment).

      Similar patch was recently merged to Qt Creator project (see https://codereview.qt-project.org/#/c/157067 ) and there was no regressions with it.

      Regards
      Alexander

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            installerteam Installer Team
            Reporter:
            sav sav
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes