Uploaded image for project: 'Qt for MCUs'
  1. Qt for MCUs
  2. QTMCU-309

PUBLIC target_compile_options for VirtualKeyboard module

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P1: Critical
    • Qt for MCUs 2.8.1
    • Qt for MCUs 2.8
    • QUL Team
    • None
    • All
    • 1e559b89, 3adabc90

    Description

      when adding VirtualKeyboard module to the QML, the VirtualKeyboard CMake files perform a PUBLIC target_compile_options call, which adds -Werror, that propagates to all our CPP files linking Qul. Moreover, it is also public linking Qul::Core which also pushes the -Werror flag to the rest of project using Qul.

      If you look at other modules, VirtualKeboard is the only module having this behavior (Controls, Shapes and other modules do not perform any PUBLIC compile option forcing).

       Like the other modules, the compile options required by VirtualKeyboard should be PRIVATE and not PUBLIC, otherwise it could break all the customer compile options...

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            k0rahman Karim Abdelrahman
            pmarvin Philippe Marvin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes