Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-1174

Gerrit fails to redirect back to the proper unified-diff page after authentication

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Not Evaluated Not Evaluated
    • None
    • unversioned
    • Gerrit
    • None

      When authenticating during a review, the Gerrit server drops one of the two slashes required to view the unified diff.

      Steps to reproduce:

      1. Log out of your Gerrit account
      2. Open one of the unified-diff review pages (for example, https://codereview.qt-project.org/#/c/186890/1//ALL)
      3. Double-click anywhere to start a line-by-line review; Gerrit redirects to accounts.qt.io
      4. Log in

      Result: You're now at https://codereview.qt-project.org/#/c/186890/1/ALL instead of https://codereview.qt-project.org/#/c/186890/1//ALL. Note the lack of the second slash before "ALL".

      Traffic inspection with the browser shows that the URL is not sent to account.qt.io, only an opaque state token. The redirection happens after GET on https://codereview.qt-project.org/login/oauth2callback: that page replies with HTTP 302 with Location: containing the wrong URL.

      PS: There's no suitable component in this JIRA project.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Unassigned Unassigned
            thiago Thiago Macieira
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes