Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-2192

Agent logging could be more robust

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • None
    • master, production
    • Coin (obsolete)
    • None

    Description

      Agent logs all messages in parallel to a file and to a remote TCP connection. If everything goes fine then it works nicely, but logging, conceptually, is very sensitive to transport layer problems. For example, it is hard to write a message to a file if the disk is full and there is no way to inform a user about that problem if the file is the only interface the user is listening to. That same applies to the remote logger. If there is no network, then we can not send any messages. In addition network usually is slower and more susceptible to failures. By handling file log and remote log in parallel we may suffer from all issues in the same time. That is why we need crazy log buffering, re-try and post network error log messages mechanizes. I think it could be simplified if we agree to send logs from agent always only to a file, we can ensure the disk space so it is quite safe option. Then on top of it we would span a goroutine that would read that file and use remote logger to upload it to coin.

       

      Alternative:

      Increase log buffer.

      Attachments

        Issue Links

          For Gerrit Dashboard: QTQAINFRA-2192
          # Subject Branch Project Status CR V

          Activity

            People

              aakeskimo Aapo Keskimölö
              nierob Nierob
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes