Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-233

Integrator hardcodes 'codereview' hostname

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P2: Important P2: Important
    • 2011q2
    • 2011q2
    • Coin (obsolete), Gerrit
    • None
    • 44e79eeb7447fcb4bddcbc9582dd6d9ece81b4c9

      Integrator currently operates in gerrit mode if the provided repository happens to contain the string 'codereview'.

      The code looks something like this:

      if self.source.repo.find('codereview') > -1:
          ...
      

      This is fragile. Also, I have heard that the ultimately intended hostname for gerrit is not intended to be the codereview.qt.nokia.com we are currently using. The hostname could potentially be switched with little warning for us, so this should be fixed soon to avoid a nasty surprise.

      We should probably just store in the CI settings whether or not the CI is using gerrit, e.g.

      def is_gerrit(self):
          return ("true" == self.git.config("--bool integration.gerrit"))
      

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            seahumad [BB] Sergio Ahumada (Inactive)
            rmcgover Rohan McGovern (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes