Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-2789

Inanity-bot now grumbles about "text following footers" if a paragraph starts "Note:"

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P3: Somewhat important
    • None
    • None
    • Sanity Bot
    • None
    • cd793f89a15478ed8ec5c0bbd9d1ca45440a9f84 (qt/qtrepotools/master)

    Description

      If a commit message contains a "Note: ..." paragraph, the 'bot now sees "Note:" as a footer-tag.
      It used to only recognise tags with hyphens in them, "Task-number:" and "Change-Id:" most obviously, but we changed that when we added support for "Fixes:", so the regex now matches "Note:" too (along with "Testing:", "Bonus:" and various other non-tags). Previously it could have also triggered on "Post-script:", "Foot-note:", "Speed-up:" or various other non-tag tokens, so this is not entirely a new problem.

      Possible solutions:

      • Grin and bear it (as we're currently doing)
      • Use a white-list as the regex, /(Task-number|Change-Id|...):/
      • Complicate the check for "text following footers"

      Combining the last two, for example, the script could keep track of what "footers" it thinks it's seen, so we could look to see whether any of a white-list of footers has been seen, particularly if the immediately preceding line is the only "footer"; if not, reclassify the "footer" as just part of the text we're seeing follow it, instead of grumbling.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            buddenha Oswald Buddenhagen
            Eddy Edward Welbourne
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes