Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-3016

Now a +2 patch that fails integration gets a broken Reviewed-by footer, that needs to be manually removed.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: P1: Critical P1: Critical
    • None
    • 2.16.7-2019-05-17-QtFork
    • Gerrit
    • None
    • 846f573e9a04f9c8cfe6c74270d8ac3651d20b27 (qtqa/gerrit-plugin-qt-workflow/v2.16.9-based)

      Now a +2 patch that fails integration gets a broken Reviewed-by footer, that needs to be manually removed.

      We add the "reviewed-by" header the moment a change gets staged, that is rather unfortunate

      The reviewed-by should only become part of the commit message when a change has been tested successfully

        For Gerrit Dashboard: QTQAINFRA-3016
        # Subject Branch Project Status CR V
        267120,12 Do not generate new patchset for each stage attempt v2.16.9-based qtqa/gerrit-plugin-qt-workflow Status: MERGED +2 0

            jujokini Jukka Jokiniva
            jujokini Jukka Jokiniva
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes