Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-3016

Now a +2 patch that fails integration gets a broken Reviewed-by footer, that needs to be manually removed.

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • None
    • 2.16.7-2019-05-17-QtFork
    • Gerrit
    • None
    • 846f573e9a04f9c8cfe6c74270d8ac3651d20b27 (qtqa/gerrit-plugin-qt-workflow/v2.16.9-based)

    Description

      Now a +2 patch that fails integration gets a broken Reviewed-by footer, that needs to be manually removed.

      We add the "reviewed-by" header the moment a change gets staged, that is rather unfortunate

      The reviewed-by should only become part of the commit message when a change has been tested successfully

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. QTQAINFRA-3156 sanity bot gives -2 "bogus reviewed-by footer" after move branch

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          relates to

          Task - A task that needs to be done. QTQAINFRA-181 Remove reviewed-by footer from +1/+2 reviewers

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTQAINFRA-3042 Failed changes cannot be re-staged

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          resulted from

          Bug - A problem which impairs or prevents the functions of the product. QTQAINFRA-3058 Staging patch in Gerrit creates new patchsets

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTQAINFRA-3016
          # Subject Branch Project Status CR V
          267120,12 Do not generate new patchset for each stage attempt v2.16.9-based qtqa/gerrit-plugin-qt-workflow Status: MERGED +2 0

          Activity

            People

              jujokini Jukka Jokiniva
              jujokini Jukka Jokiniva
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes