Details
-
Bug
-
Resolution: Fixed
-
P2: Important
-
None
-
production
-
None
Description
Copying the mail discussion:
On 10/1/19 7:12 AM, Paul Wicking wrote:
> Hi,
>
> seems sanity-bot is back in a loop of getting kicked off and then posting to reviews it doesn't consider as seen; see e.g
> https://codereview.qt-project.org/c/qt-creator/perfparser/+/275337
>
> Paul
It has never gotten out of the loop. It's connection still is cut off
every 5 minutes.
It's only visible for changes it doesn't handle correctly, though. When
it starts up, it queries all the open changes and goes through the ones
it hasn't given a score yet.
So if it works, it doesn't try to run on the same change again. This
also only happens on restart because it remembers during runtime which
changes it has already looked at. (And perhaps because it responds based
on listening to stream-events.)
I was hopeful that a Gerrit upgrade would stop these 5 min drops,
because they started after an upgrade. But unfortunately it looks like
the 3.0.2 upgrade did not help.
Real solution would be to find the cause of the 5 minute timeouts and
fix it. A workaround (which wouldn't be wrong at all even in the
presence of the real fix) would be for the bot to still give a -1
verdict when it runs into errors. That would make sure it doesn't try to
have a look at the same changes on restarts.
–
Kari