Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-3616

Failure to check for Change-Id in merges !

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Invalid
    • Affects Version/s: production
    • Fix Version/s: None
    • Component/s: Gerrit
    • Labels:
      None

      Description

      Yesterday Mitch Curtis did a merge 5.14.2 → 5.14 and managed to push it to gerrit without it having a Change-Id on it (I'm guessing git has a different hook for merges than the one it has for ordinary commits, so the hook failed to trigger for him).
      This morning, git show 5.14 thus gives me

      commit fcbbe7ff21a263f7fafb189caff4b662d4da7eda
      Merge: ad68ecf 1480922
      Author: Mitch Curtis <mitch.curtis@qt.io>
      Date:   Thu Mar 19 16:10:31 2020 +0100
      
          Merge "Merge remote-tracking branch 'origin/5.14.2' into 5.14"
      
      

      Some script should have noticed that and smacked Mitch upside the head about it before it got integrated, but apparently nothing brought to his attention the lack of a Change-Id footer.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            gerrit-admin Gerrit Admin
            Reporter:
            Eddy Edward Welbourne
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Gerrit Reviews

                There are no open Gerrit changes