Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-3662

Do not update commit time stamps while staging commits

    XMLWordPrintable

    Details

    • Type: Suggestion
    • Status: Reported
    • Priority: P1: Critical
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Gerrit
    • Labels:
      None

      Description

      Since change

       https://codereview.qt-project.org/gitweb?p=qtqa/gerrit-plugin-qt-workflow.git;a=commit;h=8da2a12a9cb4ebaf66607543e9a2379706e59d3d

      has been merged to Gerrit, Coin is forced to unpack and repack source archives every time that they are created. The double-archiving is expensive operation that takes significant cpu time and exposes Coin to strange bugs like COIN-561.

      I would suggest to amend the timestamp to the commit object (git hash-object) which will cause the commits to have different sha1s instead of tampering with the timestamps.

        Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

            Assignee:
            jujokini Jukka Jokiniva
            Reporter:
            aakeskimo Aapo Keskimölö
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There are no open Gerrit changes