Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-4589

Gerrit sends emails with duplicated message-id

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Not Evaluated
    • None
    • 2013q4
    • Gerrit
    • None

    Description

      Many times I receive messages with duplicated message-id from Gerrit. This causes all sorts of confusion in my email client (ends up ignoring some message and thus review requests).

      Example, this patch https://codereview.qt-project.org/c/qt/qtbase/+/374470

      Generated this email (which I've got because I'm subscribed to changes)

      
      Received: from codereview.qt-project.org
       (ec2-54-194-93-196.eu-west-1.compute.amazonaws.com [54.194.93.196])
       by mx.qt-project.org (Postfix) with ESMTP id 3DD2344433;
       Fri,  1 Oct 2021 09:31:06 +0200 (CEST)
      Auto-Submitted: auto-generated
      X-Gerrit-Change-Number: 374470
      X-Gerrit-ChangeURL: <https://codereview.qt-project.org/c/qt/qtbase/+/374470>
      From: "Fabian Kosmale (Code Review)" <gerrit-noreply@qt-project.org>
      Message-ID: <gerrit.1633073464000.If07ccb36bea2a5113a8f5aacf635be7d2590baf7@codereview.qt-project.org>
      X-Gerrit-PatchSet: 1
      Date: Fri, 1 Oct 2021 07:31:05 +0000
      Subject: Review Request ...qtbase[dev]: Purge Q_NO_TEMPLATE_FRIENDS and
       platforms lacking support for them
      X-Gerrit-Change-Id: If07ccb36bea2a5113a8f5aacf635be7d2590baf7
      List-Unsubscribe: <https://codereview.qt-project.org/settings>
      References: <gerrit.1633073464000.If07ccb36bea2a5113a8f5aacf635be7d2590baf7@codereview.qt-project.org>
      X-Gerrit-Project: qt/qtbase
      List-Id: <gerrit-qt-qtbase.codereview.qt-project.org>
      X-Gerrit-MessageType: newchange
      To: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
      X-Gerrit-Commit: ddef17f2144341923db624892393713bcb915b9e
      MIME-Version: 1.0
      Content-Disposition: inline
      User-Agent: Gerrit/3.1.12-13-g25307d36aa-QtFork
      Content-Type: text/plain; charset=UTF-8
      Content-Transfer-Encoding: quoted-printable
      
      Fabian Kosmale has uploaded this change for review. ( https://codereview.=
      qt-project.org/c/qt/qtbase/+/374470 )
      
      

      (skipped some uniniteresting headers). Then, I was added as reviewer, which means I've also got a second email:

      Received: from codereview.qt-project.org
       (ec2-54-194-93-196.eu-west-1.compute.amazonaws.com [54.194.93.196])
       by mx.qt-project.org (Postfix) with ESMTP id 4EC4944433
       for <giuseppe.dangelo@kdab.com>; Fri,  1 Oct 2021 09:35:30 +0200 (CEST)
      Reply-To: fabian.kosmale@qt.io, qt_sanitybot@qt-project.org,
       thiago.macieira@intel.com, lars.knoll@qt.io, oliver.wolff@qt.io,
       giuseppe.dangelo@kdab.com
      Auto-Submitted: auto-generated
      X-Gerrit-Change-Number: 374470
      X-Gerrit-ChangeURL: <https://codereview.qt-project.org/c/qt/qtbase/+/374470>
      From: "Fabian Kosmale (Code Review)" <gerrit-noreply@qt-project.org>
      Message-ID: <gerrit.1633073464000.If07ccb36bea2a5113a8f5aacf635be7d2590baf7@codereview.qt-project.org>
      X-Gerrit-PatchSet: 1
      Date: Fri, 1 Oct 2021 07:35:29 +0000
      Subject: Review Request ...qtbase[dev]: Purge Q_NO_TEMPLATE_FRIENDS and
       platforms lacking support for them
      X-Gerrit-Change-Id: If07ccb36bea2a5113a8f5aacf635be7d2590baf7
      List-Unsubscribe: <https://codereview.qt-project.org/settings>
      References: <gerrit.1633073464000.If07ccb36bea2a5113a8f5aacf635be7d2590baf7@codereview.qt-project.org>
      X-Gerrit-Project: qt/qtbase
      List-Id: <gerrit-qt-qtbase.codereview.qt-project.org>
      X-Gerrit-MessageType: newchange
      To: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
      X-Gerrit-Commit: ddef17f2144341923db624892393713bcb915b9e
      MIME-Version: 1.0
      Content-Disposition: inline
      User-Agent: Gerrit/3.1.12-13-g25307d36aa-QtFork
      Content-Type: text/plain; charset=UTF-8
      Content-Transfer-Encoding: quoted-printable
      

      You can see that this message has an identical message-id.

      I think this is https://bugs.chromium.org/p/gerrit/issues/detail?id=237 , which I'm not seeing any more with more recent gerrit installations.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gerrit-admin Gerrit Admin
            peppe Giuseppe D'Angelo
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes