Details
-
Bug
-
Resolution: Done
-
P1: Critical
-
None
-
2014q1
-
None
-
8b17acbfde3c6f86d29e62f5de14e6b9340ac3ce (qt/qtrepotools/master)
Description
I took the example from https://github.com/nickboucher/trojan-source . Please consider the other examples there as well.
See 379530. It looks as if the program will not write any output. When compiled with gcc 11.1.0, it will output "You are an admin.", though. This is because Gerrit and the compiler treat unicode characters differently, so reviewers will not see the the actual code.
Should Gerrit display a warning when it finds unicode characters in code lines?
Attachments
For Gerrit Dashboard: QTQAINFRA-4630 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
380624,4 | Ban Unicode Bi-directional override characters from all text files | master | qt/qtrepotools | Status: MERGED | +2 | 0 |
381341,2 | Match Unicode either as such or as UTF-8 | master | qt/qtrepotools | Status: MERGED | +2 | 0 |