Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-5698

As a user of Gerrit, I'd like to rely on intra-line diffs being reliable

    XMLWordPrintable

Details

    • User Story
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • Gerrit
    • None

    Description

      Reference: https://codereview.qt-project.org/c/qt/qtbase/+/491510/comment/96d309c7_4ca601b2/

      It's not the first one, either. QUIP-19 suggests to write new attributes on a separate line because developers have learned that you cannot rely on Gerrit's intra-line diffing.

      I realize this might be an upstream issue; if so, please forward it there and link the upstream issue here.

      The fact is that we're adapting our work-flows because the intra-line diffs are unreliable, let alone the extra reviewer time spent verifying line differences manually, so it's a bug in our QA tools. Please keep it open, so we can link here whenever it happens.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gerrit-admin Gerrit Admin
            mmutz Marc Mutz
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes