Details
-
User Story
-
Resolution: Unresolved
-
P2: Important
-
None
-
None
-
None
Description
Reference: https://codereview.qt-project.org/c/qt/qtbase/+/491510/comment/96d309c7_4ca601b2/
It's not the first one, either. QUIP-19 suggests to write new attributes on a separate line because developers have learned that you cannot rely on Gerrit's intra-line diffing.
I realize this might be an upstream issue; if so, please forward it there and link the upstream issue here.
The fact is that we're adapting our work-flows because the intra-line diffs are unreliable, let alone the extra reviewer time spent verifying line differences manually, so it's a bug in our QA tools. Please keep it open, so we can link here whenever it happens.