Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-5757

API change reviews can't update cleanly now that each Qt module gets its own commit

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • None
    • dev
    • qtqa module
    • None
    • All
    • 5
    • a4934f9b9 (dev)

    Description

      QTQAINFRA-4763 changed the API change review scripts to produce one commit per Qt module, within each git module. Previously, api-review-gen supported updating the monolithic commit per git module when a new version of the branch on its way to release was available. However, that's broken by having one commit per Qt module: only the last commit in the branch is available to git commit --amend, so the update can't fix up the earlier commits. This has severely broken the update process for API change reviews.

      This can be fixed by making each new commit, of a Qt module, be a git commit --fixup for the earlier commit for the same Qt module (when there is one), then ending the process with a git rebase --autosquash.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              Eddy Edward Welbourne
              Eddy Edward Welbourne
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes