Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-6843

add "--recurse-submodules=no" to downlaod / git fetch commands hint

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • None
    • Gerrit
    • None

    Description

      If you work on qtmodule which contains submodules like qtwebenigne, and your change includes updated sha for submodule which is not yet reviewed and not merged the "download" commands will not work. It will end up in error message "not our ref". This is due to the fact that indeed 3rparty sha is not in local clone as it is still on gerrit. However adding --recurse-submodules=no to fetch command solves the issue and it does not hurt to have it (have no real impact on changes in repositories which do not have submodules)

      This is quite common scenario for qtwebenigne module where changes in submodule have to be tested beforehand on ci , and there is no other way than having update commit in parent repo.

      Please note It would be helpful for people who are not aware of the issue and just want to copy paste command from gerrit "download"

      For time being you can try to checkout https://codereview.qt-project.org/c/qt/qtwebengine/+/609739 to see the issue for yourself

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gerrit-admin Gerrit Admin
            michal Michal Klocek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes