Details
-
Task
-
Resolution: Unresolved
-
P2: Important
-
None
-
None
-
None
Description
QML API Review script (https://code.qt.io/cgit/qt/qtqa.git/tree/scripts/api-review/qml-api-review) needs some improvements:
Mandatory:
- There shouldn't be a hard-coded list of modules from where reviews are generated. Script should check from code if module has QML API instead. That could be done by checking, if module
- has a .qml file in it
- with a QML_ELEMENT, or a .qml file somewhere in the code
- has qt_internal_add_qml_module in a CMakeLists.txt file.
Maybe the last one is a sufficient indicator? To be discussed with ulherman
Optional:
- It would be good if the script would push commits directly in the review. Currently it needs to be done manually, see https://intranet.qt.io/display/QTRD/How+to+create+API+reviews+for+the+release#HowtocreateAPIreviewsfortherelease-QMLAPIReview: