Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-6939

Add maintainers as reviewers to gerrit changes automatically

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • Gerrit
    • None
    • 6c3330638 (refs/meta/config), 2baefb0c6 (refs/meta/config), ebb3d91da (refs/meta/config)

    Description

      As per QTQAINFRA-169, we now have the reviewers plugin installed.

      The docs are here https://codereview.qt-project.org/plugins/reviewers/Documentation/config.md

      Now somebody needs to actually add reviewers and filters to relevant projects.

      Recently someone on IRC mentioned it would be great if reviewers are automatically added to changes, instead of them looking through git blame to find the right people.

      I suggest we at least add the maintainers from https://wiki.qt.io/Maintainers as reviewers for each respective repository, limited to a specific subdirectory if needed.

      We already have some reviewers for the qt5.git/coin folder for more than half a year, and that seems to work fine.

      To make it more /maintainable/ (pun intended), we can create separate "Qt Project Maintainers - Qt Foo module" gerrit groups, assign maintainers to them, and then create filters using those groups, similar to the qt5.git CI review groups https://codereview.qt-project.org/c/qt/qt5/+/591326/5/reviewers.config

      Then when a new maintainer is appointed or leaves, we just modify the respective maintainer group.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              gerrit-admin Gerrit Admin
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes