Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-6957

Unclear meaning of "cherry pick" when asking for a precheck Gerrit

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • Not Evaluated
    • None
    • None
    • Gerrit
    • None

    Description

      When asking for a precheck one can select "cherry pick". This is undocumented in https://testresults.qt.io/coin/doc/precheck.html

      I've assumed that it would mean to cherry pick the patch on top of the target branch, and then run CI on the result. (Instead of checking out the SHA of the commit to test, and that would include any parent commit – as well as not be necessarily done on the top of the target branch).

      In particular: if the patch was the Nth in a chain of patches, it would be cherrypicked and checked *alone* .

      It doesn't look like this is the case : https://codereview.qt-project.org/c/qt/qtbase/+/616625/21#message-cc0f852996514b2804d73e208063ae96f9a61ab7 asked for a cherry pick precheck, but there was a failure due to the parent patch , which shouldn't have been included in the precheck at all.

      So what does cherry picking do?

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            gerrit-admin Gerrit Admin
            peppe Giuseppe D'Angelo
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Gerrit Reviews

                There are no open Gerrit changes