Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7244

Cherry-pick bot does not add useful reviewers in some situations

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3: Somewhat important
    • None
    • production
    • Cherry-pick bot
    • None
    • 86af39551 (dev)

    Description

      In the event that a change is cherry-picked cleanly, but then a child pick somewhere down the line creates merge conflicts, the bot blindly copies reviewers from the immediate parent change. While the original author/owner is added to the attention set, this is ineffective if the author is external to the Qt Company, and the cherry-pick with conflicts is being applied to a tqtc/ restricted repo/branch.

      To work around this issue, the bot should parse the commit message and add reviewers according to any non-bot Reviewed By footers.

      Attachments

        For Gerrit Dashboard: QTQAINFRA-7244
        # Subject Branch Project Status CR V

        Activity

          People

            daniel.smith Daniel Smith
            daniel.smith Daniel Smith
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes