Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7307

Warn about unresolved comments when staging +2ed changes

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P3: Somewhat important P3: Somewhat important
    • None
    • master
    • Gerrit
    • None

      If somebody leaves an unresolved comment on a change that uses submissions, rather than staging (like Qt Creator repo), if it gets +2ed, and you press Submit, you get the a warning dialog as in attached screenshot.

      If you do the same for a repo that uses staging (like qtbase) there is no such warning dialog displayed, which sometimes leads to unresolved / unaddressed comments being ignored or overlooked.

      It would be nice if the same dialog is shown when pressing stage.

      I assume part of the necessary logic is there, but not applied to the staging button because it's our custom plugin. Perhaps it's not too much work to port that to be used for staging.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            daniel.smith Daniel Smith
            alexandru.croitor Alexandru Croitor
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes