Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7312

Gerrit Workflow Plugin does not throw an error on a patch which no longer applies

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P1: Critical P1: Critical
    • None
    • production
    • Gerrit
    • None
    • e6db6675f (v3.10-based)

      https://codereview.qt-project.org/c/qt/qtbase/+/571280 was allowed to be staged even though the patch had been squashed into another change and was already applied to the branch before this change was staged.

      The patch was originally squashed into https://codereview.qt-project.org/c/qt/qtbase/+/476728 months before staging this change.

      The workflow plugin should refuse to stage changes which result in an empty cherry-pick, and provide a useful error message like "Patch does not apply to

      {branch}

      ".

        For Gerrit Dashboard: QTQAINFRA-7312
        # Subject Branch Project Status CR V
        664921,3 Prevent staging of empty cherry-picked patch sets v3.10-based qtqa/gerrit-plugin-qt-workflow Status: MERGED +2 0

            gerrit-admin Gerrit Admin
            daniel.smith Daniel Smith
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes