Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7385

Update Coverity UI when a patch with Coverity-Id footer is pushed to Gerrit

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • Icon: Not Evaluated Not Evaluated
    • None
    • None
    • Gerrit
    • None

      Many developers don't update the Coverity UI as per https://wiki.qt.io/Coverity#Triage, they just fix the bug, at most adding the Coverity-Id: footer, probably expecting it to work like Task-number: does for Jira.

      Let's make their expectation true. Of course, Coverity will automatically resolve issues it no longer finds on the next run, we we don't need to track merges. But when a patch with Coverity-Id: footer gets uploaded to Gerrit as PS!, the following state changes should happen in Coverity:

      • if Action is Undecided
        • then set it to Fix Submitted
      • append (so's not to overwrite existing information) the Gerrit URL to the Ext. Reference field
        • possibly with the Jira-style (dev), 6.10 etc suffix
      • if Owner is Undefined
        • then set it to the Gerrit-owner of the change, if said Gerrit-owner has a Coverity account.
      • (maybe) copy the commit message text into the Comment field (though this may backfire: if the commit message is changed from PS1 to merged commit, the comment field is not updated in Coverity, and comments can't be edited there, once applied, either) So maybe that would be too cleverâ„¢.

      This way, we'll at least have the URLs of the Gerrit changes in Coverity's UI, and know this issue was actually fixed (if code is moved between files, it usually causes Coverity to close the issue in the old file and open a new one in the new file; such situations would stand out more).

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            gerrit-admin Gerrit Admin
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes