Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-7410

Cherry-pick bot crashes when a private change merges

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P1: Critical P1: Critical
    • None
    • production
    • Cherry-pick bot
    • None
    • eaeb2686f (dev)

      If a private change merges, the event is still broadcast over the event stream and connected webhooks. At present, the cherry-pick bot reasonably assumes that if an event for a change is received, the relevant change exists.

      Unfortunately, this means that when Gerrit returns a 404 Not Found error for a private change, the error goes unhandled and the bot crashes.

      404's should be handled gracefully with logged errors, but should never crash the bot.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            daniel.smith Daniel Smith
            daniel.smith Daniel Smith
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes