Uploaded image for project: 'Qt Tools for Android'
  1. Qt Tools for Android
  2. QTTA-437

Don't require ninja

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: P2: Important P2: Important
    • QtGP 1.4
    • QtTAS 4.1
    • QtTAS: General
    • None

      Qt builds should work fine without using ninja, so we should avoid explicitly adding "-GNinja" to the build if Ninja is not detected or setup.

      For example it's done under https://codereview.qt-project.org/gitweb?p=qt-labs/qtgradleplugin.git;a=blob;f=src/main/groovy/org/qtproject/qt/gradleplugin/QtBuildTask.groovy;h=dc2de81da88bf1f1112ce025fe4c1bd4388e301f;hb=HEAD#l274

      It should either not try to select the generator at all, or if it wants to, then it needs to check if Ninja is setup first.

      With that, we could probably also get rid of requiring users to setup Ninja path under the Qt Settings altogether. Or at least give them hints what is ninja and where/how to get it.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            nikunj Nikunj Arora
            assam Assam Boudjelthia
            Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes