Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-104589

Do not exclude QtWebEngine from CI license check

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Fixed
    • Not Evaluated
    • None
    • 6.4.0 Beta1
    • WebEngine
    • None
    • All

    Description

      Currently, qtwebengine is excluded from CI's license check.
      See https://code.qt.io/cgit/qt/qtqa.git/tree/tests/prebuild/license/tst_licenses.pl#n53

      This was done in https://codereview.qt-project.org/c/qt/qtqa/+/64576
      with the reasoning "we're copying files from Chromium and don't have their license headers under control".

      We're already ignoring everything 3rdparty. It should be possible to add SPDX license identifiers to the mentioned files such that the SPDX check passes.

      In order to resolve this we must

      • modify tst_license.pl to ignore qtwebengine only in the non-SPDX branches (< 6.4)
      • modify the source files to contain proper SPDX license identifiers

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qt_webengine_team Qt WebEngine Team
            jbornema Joerg Bornemann
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes