Details
-
Suggestion
-
Resolution: Fixed
-
Not Evaluated
-
None
-
6.4.0 Beta1
-
None
Description
Currently, qtwebengine is excluded from CI's license check.
See https://code.qt.io/cgit/qt/qtqa.git/tree/tests/prebuild/license/tst_licenses.pl#n53
This was done in https://codereview.qt-project.org/c/qt/qtqa/+/64576
with the reasoning "we're copying files from Chromium and don't have their license headers under control".
We're already ignoring everything 3rdparty. It should be possible to add SPDX license identifiers to the mentioned files such that the SPDX check passes.
In order to resolve this we must
- modify tst_license.pl to ignore qtwebengine only in the non-SPDX branches (< 6.4)
- modify the source files to contain proper SPDX license identifiers
Attachments
For Gerrit Dashboard: QTBUG-104589 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
419448,5 | Use SPDX license identifiers | dev | qt/qtwebengine | Status: MERGED | +2 | 0 |
419591,14 | Add qtwebengine to license check | dev | qt/qtqa | Status: MERGED | +2 | 0 |
420803,3 | Add qtwebengine to license check | master | qt/qtqa | Status: MERGED | +2 | 0 |
421047,2 | Use SPDX license identifiers | 6.4 | qt/qtwebengine | Status: MERGED | +2 | 0 |